Fix TreeTypeMap to correctly substitute type parameters #14537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`trace` is made for multi-line output, since it has to show large parts of programs accurately. Replacing newline with space does not work here. It messes up the layout and changes the meaning of code.
Fix TreeTypeMap to correctly substitute parameters when copying local class members. Fixes scala#12508
odersky
changed the title
|
We should also include the original example as a regression test. class Test {
inline def test(fun: => Any): Any = fun
test {
case class Pair[X, Y](
x: X,
y: Y,
)
}
}Otherwise LGTM. |
dwijnand
reviewed
Feb 22, 2022
TreeCheck fails if imports are in code that needs a change owner.
|
Original test is now included and I also fixed some other issues when mapping class hierarchies,
Together, this means that we can now map embedded enums. |
If sealed classes are mapped in TypeTreeMap or mapSymbols, their children have to be mapped accordingly.
nicolasstucki
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TreeTypeMap to correctly substitute parameters when copying local class members.
Fixes #12508