Scaladoc: fix #14481: certain functions not being shown in searchbar #14546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pikinier20
reviewed
Feb 24, 2022
Allows to search for public members inherited from hidden classlikes in Scaladoc. Additionally, to avoid confusing users about the missing link in the "Inherited from:" field, a "(hidden)" adnotation was also added. A "inheritedMembersFromHidden" Signature Test was also added.
jchyb
force-pushed
the
scaladoc/searchbar-inherited-hidden
branch
from
78bd5a9
to
598b8d3
Compare
jchyb
changed the title
|
@pikinier20 I've noticed now that I've misnamed this PR before - the methods were only missing from searchbar. Nevertheless I've added a SignatureTest for an example use case this issue presents. As for the searchbar itself, any StdIn method (e.g. readBoolean) would not show up there before. This is because they are being inherited from package private trait, rendering it inaccessible in API. |
pikinier20
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to search for public members inherited from hidden classlikes in Scaladoc. Additionally, to avoid confusing users about the missing link in the "Inherited from:" field, a
(hidden)adnotation was also added to the superclass name of those function members.Fixes #14481