Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table of content to static sites #14607

Merged
merged 4 commits into from Mar 17, 2022

Conversation

pikinier20
Copy link
Contributor

No description provided.

scaladoc/resources/dotty_res/scripts/ux.js Outdated Show resolved Hide resolved
@pikinier20
Copy link
Contributor Author

I just realized that this approach won't work well if the section is longer than one page. This PR can't be merged until we fix it.

@julienrf
Copy link
Collaborator

julienrf commented Mar 3, 2022

@pikinier20 what do you mean by “the section longer than one page”?

The PR sounds like a great improvement :) Do you have a screenshot?

@pikinier20
Copy link
Contributor Author

pikinier20 commented Mar 7, 2022

@pikinier20 what do you mean by “the section longer than one page”?

I mean that if the content of section is longer than one screen, then the javascript that highlights proper sections won't work. It checks if the header of section is present on page. With longer content, the header is invisible but the content is still on the screen.

@pikinier20 pikinier20 force-pushed the scaladoc/rhs-table-of-content branch 2 times, most recently from 9699b6d to 67062aa Compare March 8, 2022 12:08
@pikinier20
Copy link
Contributor Author

@julienrf
Copy link
Collaborator

julienrf commented Mar 9, 2022

The table of contents overlaps with the “next page” link:

Screenshot from 2022-03-09 13-43-01

Do you know if there are examples of pages with sections of various levels (h1, h2, h3, etc.)?

@pikinier20 pikinier20 force-pushed the scaladoc/rhs-table-of-content branch from 67062aa to a0f612f Compare March 15, 2022 13:56
@pikinier20
Copy link
Contributor Author

The table of contents overlaps with the “next page” link:

Screenshot from 2022-03-09 13-43-01

Do you know if there are examples of pages with sections of various levels (h1, h2, h3, etc.)?

I've refactored the arrows since they were a bit inconsistent with the rest of the design. Right now, the anchors to previous and next page are located at the bottom of the page like in e.g. webhelp format.

@julienrf
Copy link
Collaborator

I find that the links to the previous and next pages are hard to see. Would it be possible to move them above the list of contributors, maybe?

@pikinier20 pikinier20 force-pushed the scaladoc/rhs-table-of-content branch from a0f612f to 85ed11d Compare March 15, 2022 14:25
@pikinier20
Copy link
Contributor Author

I find that the links to the previous and next pages are hard to see. Would it be possible to move them above the list of contributors, maybe?

That's not that easy because contributors are added by another template :/

@pikinier20
Copy link
Contributor Author

@julienrf I've moved the arrows above contributors

Copy link
Collaborator

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Filip!

I think this is good to go.

@pikinier20 pikinier20 merged commit 1a5b165 into scala:main Mar 17, 2022
@pikinier20 pikinier20 deleted the scaladoc/rhs-table-of-content branch March 17, 2022 10:47
@Kordyjan Kordyjan added this to the 3.1.3 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants