Fix bounds of match type cases #14645
Conversation
dwijnand
force-pushed
the
match-type/reduce-tparam-bounds-pr
branch
from
d67ceec
to
0e578f1
Compare
…s for the applied arguments
dwijnand
force-pushed
the
match-type/reduce-tparam-bounds-pr
branch
from
0e578f1
to
3a00dc5
Compare
dwijnand
changed the title
There was a problem hiding this comment.
I don't have a full understanding of the match type logic but my gut reaction here is that this is a lot of code in TypeAssigner which is supposed to be mostly straightforward. Can we ensure these symbols have the correct info at the point they're created (both in typer and treeunpicker) instead?
|
I don't see how to do that. The loop is in typing the arg of the AppliedTypeTree (typedAppliedTypeTree) and the symbols are created in typing the bind (typedBind). In my example I need the symbol for A so I can use it as the upper bound of the symbol for X. But there's no restriction on the definition order, so I could be typing the binding for X before I've even got a symbol for A. So unless you can see another way to pipe and order things, I propose we use the substitute mechanism to post-process them. There's seems to be a bunch of precedent for doing things very similarly to how I am, or at least to my eyes... |
|
cc also @odersky, in case he can recommend better ways or places to do this. |
No description provided.