Filter out static forwarders for Java package private methods #14662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
requested changes
Mar 10, 2022
| @@ -0,0 +1,12 @@ | |||
| object MyClassValue extends ClassValue[String] { | |||
There was a problem hiding this comment.
This test isn't guaranteed to keep working since the JDK might add new public methods to ClassValue at any moment. Could you make a test with a custom .java file instead? To test separate compilation the java file needs to end with _1 and the scala file with _2 and both need to be in a subdirectory like in https://github.com/lampepfl/dotty/tree/main/tests/run/java-intersection (checkfile in https://github.com/lampepfl/dotty/blob/main/tests/run/java-intersection.check)
Co-authored-by: Guillaume Martres <smarter@ubuntu.com>
vasilmkd
force-pushed
the
java-package-private-forwarders
branch
from
3b8cab4
to
cf71532
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14624.
Thank you @smarter, from the bottom of my heart.