Reject postfix ops already in Parser #14677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse a postfix op only if language.postfixOps is imported. This helps avoiding non-sensical parses. Previously we always parsed, but issued errors in Typer if postfix ops were not enabled.
pikinier20
approved these changes
Mar 14, 2022
| infixOps(t, in.canStartExprTokens, prefixExpr, location, | ||
| isType = false, | ||
| isOperator = !(location.inArgs && followingIsVararg()), | ||
| maybePostfix = true) |
There was a problem hiding this comment.
I wonder whether just changing there the value of maybePostfix to in.postfixOpsEnabled wouldn't do the same as all these parser changes.
I mean, this is the only place where we set ParseKind.Expr so instead of checking if the postfix is enabled in infixOps, we can do it here.
There was a problem hiding this comment.
No, since even with postfixOpsEnabled we do not allow postfix ops in patterns and types.
There was a problem hiding this comment.
Yes, but for these cases the maybePostfix parameter was already by default false.
|
Yes, true, but I chose to do a three-way enumeration instead of two booleans for clarity. It's not a big deal either way, I agree. |
|
Okey, I see. The clarity is indeed better with enums. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse a postfix op only if language.postfixOps is imported. This helps avoiding
non-sensical parses and confusing error messages. Previously we always parsed,
but issued errors in Typer if postfix ops were not enabled.
Also: drop language.postfixOps as a default option in build and test
Fixes #14564