Remove false unchecked warnings on refined types #14703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
approved these changes
Mar 20, 2022
dwijnand
force-pushed
the
checkable-isInstanceOf-RefinedType
branch
from
b53fdea
to
1b3b399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Driven by the warnings that came out of studying a fix for #11834 (which we might resolve by making the situation impossible), I have a refactor of our typed/untyped trees which uses type members instead of type parameters (i.e. refined types instead of applied types). But doing a type test, via isInstanceOf or via pattern matching syntax, on a refined type (also) can produce spurious, i.e false positive, unchecked warnings. So with this fix I get rid of the fatal warnings in boostrapping the compiler with my Trees refactor.