Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix desugaring empty argument blocks in normArgs #14719

Merged
merged 2 commits into from Mar 21, 2022
Merged

Fix desugaring empty argument blocks in normArgs #14719

merged 2 commits into from Mar 21, 2022

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Mar 20, 2022

Fixes #14699

@soronpo
Copy link
Contributor

soronpo commented Mar 20, 2022

@odersky This PR has the commit from #14716. Is that on purpose?

@odersky odersky requested a review from soronpo March 20, 2022 16:13
@odersky
Copy link
Contributor Author

odersky commented Mar 20, 2022

It was not on purpose, but it's fine since I merged #14716 since.

soronpo
soronpo approved these changes Mar 20, 2022
View reviewed changes
Copy link
Contributor

@soronpo soronpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@odersky odersky merged commit c9d33a8 into scala:main Mar 21, 2022
@odersky odersky deleted the fix-14699 branch March 21, 2022 09:08
@Kordyjan Kordyjan added this to the 3.1.3 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soronpo soronpo soronpo approved these changes

Assignees

@soronpo soronpo

Labels
None yet
Projects
None yet
Milestone
3.1.3
Development

Successfully merging this pull request may close these issues.

Overloading regression in Scala 3
3 participants
@odersky @soronpo @Kordyjan