Extend "cannot override mutable variable" restriction to deferred var… #14724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iables. Extend "cannot override mutable variable" restriction also to deferred variables. This aligns the behavior with Scala 2. Fixes scala#14722
smarter
reviewed
Mar 21, 2022
| @@ -10,4 +10,4 @@ class Ok2C extends Ok2 { override var i: Int = 1 } | |||
|
|
|||
| // was: variable i of type Int cannot override a mutable variable | |||
| trait NotOk {var i: Int} | |||
| class NotOkC extends NotOk { override var i: Int = 1 } | |||
| class NotOkC extends NotOk { override var i: Int = 1 } // error | |||
There was a problem hiding this comment.
If this breaks it means we're not really aligned with Scala 2 and we need to re-open #13019 /cc @som-snytt . The Scala 2 logic here is scala/scala@9b59f5f
There was a problem hiding this comment.
In my tweak I didn't try trait params. I'll take another look at a fix. I haven't taken the trait params coursera yet.
smarter
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iables.
Extend "cannot override mutable variable" restriction also to deferred variables.
This aligns the behavior with Scala 2.
Fixes #14722