Fix #14726: call exclusiveLower before addLess during unification #14727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abgruszecki
reviewed
Mar 24, 2022
|
Excellent, great job @Linyxus! This LGTM now, we'll merge if the tests pass. |
abgruszecki
approved these changes
Mar 24, 2022
|
It seems that the checks are not triggered for the latest commit. Is it possible to run it manually? |
…s during unification
auto-merge was automatically disabled
March 25, 2022 06:05
Head branch was pushed to by a user without write access
|
It seems that for some reason the results from the run is not reported in the PR. I force pushed to the branch (and squash the two fixing commits into the same one by the way); the checks are running now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #14726. By calling
exclusiveLowerbeforeaddLess, we can properly propagate GADT upper bounds to lower parameters.