Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle this prefix in objects (in quote patterns) #14732

Merged
merged 1 commit into from Mar 23, 2022
Merged

Handle this prefix in objects (in quote patterns) #14732

merged 1 commit into from Mar 23, 2022

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Mar 21, 2022 •
edited

Fixes #14536

@nicolasstucki nicolasstucki force-pushed the fix-14536 branch 2 times, most recently from 454284f to 3b09c0e Compare March 22, 2022 14:25
@nicolasstucki nicolasstucki marked this pull request as ready for review March 23, 2022 14:20
@nicolasstucki
Copy link
Contributor Author

The issue is that the scrutiny contained and Ident reference to a method in an object O and the pattern expected a Select where the prefix is extracted (i.e. has a hole). The issue happens only if the call is inside the object O.

The solution is to detect these situations and create the tree for the prefix of the selection and compare it with the prefix of the pattern. If those match, the prefix will be bound the to quote pattern splice variable.

@smarter smarter merged commit 03085e0 into scala:main Mar 23, 2022
@smarter smarter deleted the fix-14536 branch March 23, 2022 14:42
nicolasstucki added a commit to dotty-staging/dotty that referenced this pull request Mar 28, 2022
@nicolasstucki
Handle this prefix in classes (in quote patterns) scala#14732
9d5d5e4 
Fixes scala#14788
nicolasstucki added a commit to dotty-staging/dotty that referenced this pull request Mar 31, 2022
@nicolasstucki
Handle this prefix in classes (in quote patterns) scala#14732
250533c 
Fixes scala#14788
michelou pushed a commit to michelou/dotty that referenced this pull request Apr 25, 2022
@nicolasstucki @michelou
Handle this prefix in classes (in quote patterns) scala#14732
45bf86b 
Fixes scala#14788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

Assignees

@smarter smarter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quotes pattern matching on object's member
2 participants
@nicolasstucki @smarter