Fix hasKnownMembers #14762
Merged
Fix hasKnownMembers #14762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As observed in scala#13900, hasKnownMembers gives problematic false positives. What we are really after is a (nontrivial) upper approximation of known members. Even uninstantiated type variables have such an approximation if their lower bound is defined and different from Nothing. Fixes scala#13900
|
Test performance please |
1 similar comment
|
Test performance please |
Turns out we cannot make TypeParamRefs have unknown members directly. scala.concurrent.TrieMap fails if we do that.
smarter
requested changes
Mar 24, 2022
smarter
approved these changes
Mar 24, 2022
Co-authored-by: Guillaume Martres <smarter@ubuntu.com>
|
Test performance please |
|
test performance please |
|
performance test scheduled: 11 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/14762/ to see the changes. Benchmarks is based on merging with main (a2974d9) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As observed in #13900, hasKnownMembers gives problematic false positives. What we are
really after is a (nontrivial) upper approximation of known members. Even uninstantiated
type variables have such an approximation if their lower bound is defined and different
from Nothing.
Fixes #13900