Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated batch files (issue 15220) #15325

Merged
merged 1 commit into from May 31, 2022

Conversation

michelou
Copy link
Collaborator

@michelou michelou commented May 30, 2022

Updated batch files to address issue 15220.

Testing was performed by crossing three parameters :

  • targeting both the 3.1.3-RC4 distro and a locally generated 3.2.0-RC1-nightly build.
  • targeting small Scala projects from my GitHub repository michelou/dotty-examples.
  • running several kinds of build scripts which rely on those batch files, e.g. build.bat (batch file), Makefile (GNU Make), build.xml (Apache Ant) and pom.xml (Apache Maven).

NB. The changes published in this PR target both

and are limited to the dist/bin/ directory.

@michelou michelou requested a review from bishabosha May 30, 2022 12:39
@michelou michelou self-assigned this May 30, 2022
@anatoliykmetyuk anatoliykmetyuk requested review from anatoliykmetyuk and removed request for bishabosha May 30, 2022 14:04
@bishabosha bishabosha added the backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" label May 30, 2022
@michelou
Copy link
Collaborator Author

michelou commented May 30, 2022

@anatoliykmetyuk I have two remarks :

  • Can you take care of the merge operation into the 3.1.3 branch or should I create another PR against that branch ?
  • Merge into the main branch should take place before June 1st, the planned date for release 3.2.0-RC1.

@bishabosha
Copy link
Member

bishabosha commented May 31, 2022

its ok there isn't a rush to do the backport as there will be 3.1.3-RC5

@anatoliykmetyuk anatoliykmetyuk merged commit 9caafb9 into scala:main May 31, 2022
@anatoliykmetyuk
Copy link
Contributor

Can you take care of the merge operation into the 3.1.3 branch or should I create another PR against that branch ?

I don't know the current procedure for those backports, @prolativ do you know anything about how it is done?

@prolativ
Copy link
Contributor

@Kordyjan is doing the backports for this release

@michelou michelou deleted the dotty-batch-15220 branch May 31, 2022 15:08
@Kordyjan Kordyjan added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tooling backport:done This PR was successfully backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants