-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide an "Unreleased" section in CHANGELOGs to support & organise contributor proposed changes #3710
Comments
@xurizaemon I'm down with that. In the past I've just put "TBD" for the date and left the presumptive version. That way when merging in a PR, all the maintainer has to do is update the date (and, if needed, the release version) in a quick commit from the GitHub interface before making the release. But "Unreleased" is clearer and only involves a minor extra copy/paste/edit for the maintainer. |
Great! My proposal here (just so we have something specific to discuss) is the addition of ## Unreleased
at the top of each Lando project's CHANGELOG.md (above the most recent release). Adopting Keep a Changelog (as a stretch goal?) is IMO a fine idea 😄 it saves Lando team having to make decisions and gives you a well-documented approach, but that's for core team to decide. |
Agreed, I put in a ticket on |
So, i've updated https://github.com/lando/prepare-release-action to automate this. the If you want to have it work on the next release you need to add the correct tokens at the top of the ## {{ UNRELEASED_VERSION }} - [{{ UNRELEASED_DATE }}]({{ UNRELEASED_LINK }})
every release these will be correctly populated and a new set of tokens will be prepended to the probably safe to close this out but will leave that to @xurizaemon and @reynoldsalec |
From @uberhacker last couple PRs we got talking about proposing changes to the CHANGELOG in PRs.
Problem:
In recent PRs this came up in review (lando/acquia#95 (comment), lando/backdrop#47 (comment)). It's not exactly a roadblock, and but I think it's an opportunity to ensure the default path is straightforward.
Being uncertain about details (eg questions like "Will my change increment the patch, minor or major release?") shouldn't be an impediment to proposing changes. Contributors, esp new ones, may be uncertain or unaware of impact here, and that may add friction / resistance to the process for them.
I propose the addition of an "Unreleased" section at the top of each repo CHANGELOG, per https://keepachangelog.com
PRs can then add changes to the new Unreleased section, and at release time the maintainer inserts the heading above changes in the released version. From the KeepAChangelog website:
There are other approaches (from fully embracing Keep a Changelog, or tools which manage the changelog for you). This issue kicks off by presenting the current challenge and a minimal approach to addressing it.
The text was updated successfully, but these errors were encountered: