Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event "before-end" doesn't execute anything #3711

Open
acha5066 opened this issue Apr 30, 2024 · 1 comment
Open

Event "before-end" doesn't execute anything #3711

acha5066 opened this issue Apr 30, 2024 · 1 comment
Labels
bug Something aint working right! v4 Something to consider for Lando v4

Comments

@acha5066
Copy link

I debugged the available events by running lando start -vvv | grep "emitting" and noticed that the before-end event is fired right at the last moment. I tried to use this to execute a script but it appears nothing happens.

To test this, I executed my custom script with the post-start event and set -xe at the top of my script so I can see it is executing. It is executed with post-start but this happens too early, before the service that appserver depends on is ready. Nothing happens with before-end.

I'm not sure why before-end doesn't execute 🤔 but I actually think a post-healthcheck event that fires after all services have been checked would be better here.

As a temporary workaround I've added a delay to my script to wait for the service to be ready.

Using Lando version v3.20.8

@acha5066 acha5066 added the bug Something aint working right! label Apr 30, 2024
@reynoldsalec
Copy link
Sponsor Member

Interesting, I'm going to throw a Lando 4 tag on this in case it's helpful for thinking about Lando 4 architecture...guessing since most energy is going towards working on v4 that there won't be much action here for looking at the events functionality in v3, but definitely thanks for pointing this out @acha5066 and glad you found a workaround, even if it's not ideal.

@reynoldsalec reynoldsalec added the v4 Something to consider for Lando v4 label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something aint working right! v4 Something to consider for Lando v4
Projects
None yet
Development

No branches or pull requests

2 participants