Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deutsch edit app #4270

Merged
merged 2 commits into from May 11, 2024
Merged

fix: deutsch edit app #4270

merged 2 commits into from May 11, 2024

Conversation

YidaHu
Copy link
Contributor

@YidaHu YidaHu commented May 10, 2024

Description

Fixed the edit app issue in Deutsch.

At the same time, I found that De app.ts files are very different from other languages.

Fixes #4235

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. 🐞 bug Something isn't working labels May 10, 2024
@takatost takatost requested a review from JzoNgKVO May 10, 2024 14:35
crazywoola
crazywoola requested changes May 11, 2024
View reviewed changes
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  editAppTitle: 'Edit App Info',
  editDone: 'App info updated',
  editFailed: 'Failed to update app info',

Missing these 3 lines :)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 11, 2024
@YidaHu
Copy link
Contributor Author

YidaHu commented May 11, 2024 

  editAppTitle: 'Edit App Info',
  editDone: 'App info updated',
  editFailed: 'Failed to update app info',

Missing these 3 lines :)

OK, done

@crazywoola crazywoola merged commit 1e45199 into langgenius:main May 11, 2024
7 checks passed
@YidaHu YidaHu deleted the fix/deutsch-edit-app branch May 11, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

@JzoNgKVO JzoNgKVO Awaiting requested review from JzoNgKVO

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Edit Info" does not display correctly with german language settings
2 participants
@YidaHu @crazywoola