Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LongSentenceRule shows confusing behavior #10550

Open
FredKruse opened this issue Apr 29, 2024 · 5 comments
Open

LongSentenceRule shows confusing behavior #10550

FredKruse opened this issue Apr 29, 2024 · 5 comments

Comments

@FredKruse
Copy link
Contributor

The LongSentenceRule shows confusing behavior. By default, sentences longer than 40 words are fully underlined. If there is only one other error within the sentence, the match of the LongSentenceRule is not displayed.
It becomes completely confusing for the user if, for example, the optional LongParagraphRule is activated and also reports an error. It will not be displayed as long as the LongSentenceRule is enabled, even if the sentence underline is not displayed due to another error. If the LongSentenceRule is deactivated in this case, the match of the LongParagraphRule, which only underlines the word at which the number of maximum permitted words is exceeded, is displayed correctly.
The easiest way to change this behavior is to shorten the underline of the LongSentenceRule. My suggestion: Underline the last word inside the limit and the first outside. This gives the user additional information about where the sentence must be split at the latest.
@danielnaber
I prepared and tested this change. If nothing speaks against it, I would do it.

@danielnaber
Copy link
Member

If nothing speaks against it, I would do it.

We need to underline the whole sentence if we have a suggestion. We currently don't, but we might in the future.

@FredKruse
Copy link
Contributor Author

Is there a way to turn off the filter so that all errors are output? That would be helpful for the extension.

@danielnaber
Copy link
Member

There's setCleanOverlappingMatches(boolean) in JLanguageTool

@FredKruse
Copy link
Contributor Author

In my latest version (still as a branch) I work with my own LO-specific handling of overlapping matches. For the local version, this works fine. I would now like to extend this to the remote function. Hence, the question:
Can the filtering of hits be switched off from a client to a server?

@danielnaber
Copy link
Member

Can the filtering of hits be switched off from a client to a server?

I don't think there's an option for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants