Work in progress on reimplementing existing features from Druid Lapce in Floem Lapce

[MinusGix]

The Floem (UI library) version of Lapce will be has been merged into the master branch soon. Once that occurs, bringing it completely up to feature parity with the druid version of Lapce is needed. There is a variety of missing features, some of which were skipped over and some of which have happened since the fork, that need to be reimplemented.

Easy: Features that are just a matter of porting code over

• Completion Lens (Impl completion lens #2425)
• IME phantom text
  • might be blocked by backend?
• Various missing workbench commands
  • Enable/Disable modal mode (fix:reimplementing EnableModal and DisableModal command #2458 )
  • CloseFolder (fix: reimplementing CloseFloder command #2432)
  • Change color theme
  • Change icon
  • New Window / Close Window: These probably just need some way to send a command to the appdata to tell it to construct a new window
  • Change File language (Fix: reimplementing ChangeFileLanguage command #2474)
  • ....
• Make changing modal mode via palette or settings update the cursors. See this
• Display keybinds in palette (fix: reimplementing display keybinds in palette #2461 )
• Log files don't seem to be hooked up? Also need to impl WorkbenchCommand::OpenLogFile (feat: replace log with tracing and implement observability #2466)
• Show file language in status bar (Fix reimpl show language in status #2477)
• Show cursor line/column/character in status bar (fix: re-implement cursor info #2482)
• Add the 'About' panel back. (Re-implemented "About Lapce" popup. #2526)
• Allow binding mouse buttons to commands (Allow binding mouse buttons to commands #2573 )
• Ctrl/Cmd + Click for goto definition (Goto definition does not work on macOS using Cmd+MouseLeft #2801)

Medium: May need a good amount of changes and work

• Add scratch files
• MacOS menu bar integration. Does the backend support this at the moment? Might need to be exposed by Floem? Uncertain.
  • Create new file
  • Open folder
  • Whatever other bits we had previously! (TODO: put link to definition here.)
• Closing the window on MacOS closes the program, when it should be kept around like typical programs
• Keyboard shortcuts view (and its associated workbench command)
• Resize panels
• Resize splits
• Open Folder file picker for remote
• Signature view
• Figure out keybind behavior properly.

Hard: May be intricate to implement, even with the existing implementation. Either due to backend differences or other problems.

• Diff Editor (Diff editor #2499 )
  • Should be separate from the document instead.
• Proper Wayland support
  • Floem uses (a slightly modified version of) glazier. There is currently an in-progress wayland implementation being tracked at Wayland backend: Features to implement linebender/glazier#118.

[TitanNano]

Wayland support is also no longer a thing.

[WeetHet]

And basically nothing works on macos anymore

[MinusGix]

And basically nothing works on macos anymore

Can you be more specific? I believe dzhou uses the editor on macos, so editing works (etc). Is there a specific feature that's missing? A specific integration with MacOS?

[WeetHet]

And basically nothing works on macos anymore

Can you be more specific? I believe dzhou uses the editor on macos, so editing works (etc). Is there a specific feature that's missing? A specific integration with MacOS?

1. No macOS menu bar integration, meaning no way to open a folder/create new file as
2. Shortcuts don't seem to work
3. LSP also is not working at all somehow
4. Closing last window closes the app — not macOS way of doing things
5. And probably a lot more stuff I didn't found in the first thirty seconds of using nightly build

[MinusGix]

Thanks. I'll add those to the list and discuss them.

3. LSP also is not working at all somehow

Which specific LSP?

[WeetHet]

Thanks. I'll add those to the list and discuss them.

3. LSP also is not working at all somehow

Which specific LSP?

Rust

[panekj]

am using nightly version many weeks now and was fine just last update break all

as I said, that is expected, we're rewriting most of the codebase, use stable release if you want working editor

[tk103331]

Are there only these tasks to handle? There are still many differences when I run the floem version.

[panekj]

Are there only these tasks to handle? There are still many differences when I run the floem version.

These are the only written down. If something is missing, it should be noted here.

[WeetHet]

On macOS (and linux probably?) the keybindings are weird for colemak. Instead of using real keystrokes, lapce seems to use "places" on the keyboard. For example to press Cmd+N and create a new file, one should press Cmd+K, as the position of K in Colemak coincides with position of N in QWERTY. This should be changed, so lapce would use real key inputs and not their places (see #2800)

[WeetHet]

Also #2801

[WeetHet]

@MinusGix mind adding this two to the list? Also menu bar support on macOS seems to be long gone again