key rev is ignored for dependency (tracing)

[nunotexbsd]

Lapce Version

0.4.0

System information

FreeBSD 14.0 / Rust 1.77.0

Describe the bug

Can't compile:

error: failed to load manifest for workspace member `/wrkdirs/usr/ports/editors/lapce/work/lapce-0.4.0/lapce-app`

Caused by:
  failed to parse manifest at `/wrkdirs/usr/ports/editors/lapce/work/lapce-0.4.0/lapce-app/Cargo.toml`

Caused by:
  key `rev` is ignored for dependency (tracing).

Additional information

Trying to compare Cargo.{lock,toml} from 0.3.1 version but can't find what causing this error.

[panekj]

Cargo.lock is not relevant, it doesn't participate in workspace manifest. It seems to be that you have some kind of modified source which isn't exactly from us.

[nunotexbsd]

@panekj

Hello,

I got some help on lapce port and it builds ok with following patch. I can't understand why it fixed configure stage but here it is and maybe upstream could find a better understanding:

--- Cargo.toml.orig     2024-04-24 20:32:06 UTC
+++ Cargo.toml
@@ -61,6 +61,10 @@ url               = { version = "2.5.0" }
 toml              = { version = "*" }
 toml_edit         = { version = "0.20.2", features = ["serde"] }
 url               = { version = "2.5.0" }
+tracing           = { git = "https://github.com/tokio-rs/tracing", rev = "908cc432a5994f6e17c8f36e13c217dc40085704", package = "tracing" }
+tracing-log       = { git = "https://github.com/tokio-rs/tracing", rev = "908cc432a5994f6e17c8f36e13c217dc40085704", package = "tracing-log" }
+tracing-subscriber = { git = "https://github.com/tokio-rs/tracing", rev = "908cc432a5994f6e17c8f36e13c217dc40085704", package = "tracing-subscriber" }
+tracing-appender = { git = "https://github.com/tokio-rs/tracing", rev = "908cc432a5994f6e17c8f36e13c217dc40085704", package = "tracing-appender" }

 lsp-types = { version = "0.95.1", features = ["proposed"] }                                                  # not following semver, so should be locked to patch version updates only
 psp-types = { git = "https://github.com/lapce/psp-types", rev = "f7fea28f59e7b2d6faa1034a21679ad49b3524ad" }
@@ -75,30 +79,8 @@ floem-editor-core = { git = "https://github.com/lapce/
 # floem-editor-core = { path = "../workspaces/floem/editor-core/", features = ["serde"] }

 [patch.crates-io]
-# Temporarily patch lsp-types with a version that supports inline-completion
-lsp-types = { git = "https://github.com/lapce/lsp-types", rev = "feaa1e2ec80975c9dadd400a238ceacf071058e6" }
-regalloc2 = { rev = "5d79e12d0a93b10fc181f4da409b4671dd365228", git = "https://github.com/bytecodealliance/regalloc2" }
-
-
-[workspace.dependencies.tracing]
-git     = "https://github.com/tokio-rs/tracing"
-rev     = "908cc432a5994f6e17c8f36e13c217dc40085704"
-package = "tracing"
-
-[workspace.dependencies.tracing-log]
-git     = "https://github.com/tokio-rs/tracing"
-rev     = "908cc432a5994f6e17c8f36e13c217dc40085704"
-package = "tracing-log"
-
-[workspace.dependencies.tracing-subscriber]
-git     = "https://github.com/tokio-rs/tracing"
-rev     = "908cc432a5994f6e17c8f36e13c217dc40085704"
-package = "tracing-subscriber"
-
-[workspace.dependencies.tracing-appender]
-git     = "https://github.com/tokio-rs/tracing"
-rev     = "908cc432a5994f6e17c8f36e13c217dc40085704"
-package = "tracing-appender"
+lsp-types = { path = '../lsp-types-feaa1e2ec80975c9dadd400a238ceacf071058e6' }
+regalloc2 = { path = '../regalloc2-5d79e12d0a93b10fc181f4da409b4671dd365228' }

 [workspace.dependencies.alacritty_terminal]
 version = "0.23.0"

[panekj]

Did you try using vendor tarball? It has the Cargo dependency manifest and all dependencies already present, so you could just swap out it in build

[nunotexbsd]

I will try vendor tarball and figure out how to interact with our ports framework.

Thanks!