Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

Add CI for code style verifications #268

Open
igorsantos07 opened this issue May 9, 2015 · 7 comments
Open

Add CI for code style verifications #268

igorsantos07 opened this issue May 9, 2015 · 7 comments

Comments

@igorsantos07
Copy link
Member

It's imperative we include Travis CI support to verify code styling issues, as PRs usually come with different code styles and that reduces code quality.

In the future we can use this integration for tests as well.

Suggestion: verify how Faker does it.

@GrahamCampbell
Copy link

It's imperative we include Travis CI support to verify code styling issues

Check out https://styleci.io/. :)

@GrahamCampbell
Copy link

That way you can keep travis reserved for the unit tests, and have styleci giving an additional green/red light on PRs.

@igorsantos07
Copy link
Member Author

That's awesome! I didn't know that service.
I though on Travis as it had integration and I saw it working fine on Faker.

@igorsantos07
Copy link
Member Author

Unable to implement StyleCI. I'm not the owner of the project... And I'm quite sure @laravelbook won't even try to reply us.

@igorsantos07
Copy link
Member Author

I'll send him an email asking for help. TravisCI behaves the same way (why did I though it would be different? lol)

@GrahamCampbell
Copy link

@igorsantos07 If you need any help, feel free to contact me, and I can help you get set up, though I can't manually enable this repo on StyleCI for you until someone with admin permissions on this repo has an account on StyleCI because we'd be using their authentication token in order to use GitHub's status API. Non-admin users don't have permission to write to the status API for their repos you see. :)

@igorsantos07
Copy link
Member Author

Yeah... That's way too bad. Not because of the API, but the other way
around: the original owner of this code vanished. I couldn't find any
reference about him on the Web.
I don't think I have any access to packagist stuff as well, so it's also
hard to transfer the composer package to my fork.

I'll try to investigate things later today and see what I can came up with
:(
On 10 May 2015 06:40, "Graham Campbell" notifications@github.com wrote:

@igorsantos07 https://github.com/igorsantos07 If you need any help,
feel free to contact me, and I can help you get set up, though I can't
manually enable this repo on StyleCI for you until someone with admin
permissions on this repo has an account on StyleCI because we'd be using
their authentication token in order to use GitHub's status API. Non-admin
users don't have permission to write to the status API for their repos you
see. :)


Reply to this email directly or view it on GitHub
#268 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants