Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] change mapping_file config name to mappings_config_key #348

Open
gadelkareem opened this issue Aug 30, 2018 · 0 comments
Open

Comments

@gadelkareem
Copy link

The mapping_file config is misleading because it internally look for the config key in the application. Moving the config into another path will cause the mappings to break while no instructions to load the mappings config dynamically.

Package version, Laravel version

5.6

Steps to reproduce the behaviour

Moving the config file mappings.php into another path will cause the mappings to break while no instructions to load the mappings config dynamically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant