[FEATURE]New database factory system #526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Remove factory relationships.
Codecov Report
@@ Coverage Diff @@
## 1.8 #526 +/- ##
============================================
+ Coverage 54.49% 55.32% +0.82%
- Complexity 824 889 +65
============================================
Files 101 103 +2
Lines 2325 2500 +175
============================================
+ Hits 1267 1383 +116
- Misses 1058 1117 +59
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…ory system and laravel default
|
Looks good to me |
k0ka
added a commit
to k0ka/laravel-doctrine-docs
that referenced
this pull request
Aug 27, 2022
Assertions documentation
|
Please let me know if you have any questions or need any assistance from me. |
|
Any news regarding this? should be awesome to have this running.... |
|
Hey all, I'm new to laravel-doctrine but love having good testing utilities. Is there anything we can do to help move this along? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
The new database factory system is added, it was copied from the Laravel Eloquent modern factories https://laravel.com/docs/9.x/database-testing
Everything except Factory relationships has been implemented and works for Doctrine.
The new system is object-oriented, easily extensible, doesn't use any magic files and supports IDE autocompletion.
Fixes #470
Changes to be done
Please let me know if this PR looks good, and I'll add documentation (actually copy-paste it from the Laravel).
The current implementation of database factories
While Laravel moved the old factory system into another package laravel/legacy-factories, we might leave it for backward compatibility as both systems can coexist without any problem.