New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] PrimaryReadReplica doesn't work #560

Open

gierappa opened this issue Aug 9, 2023 · 0 comments

gierappa commented Aug 9, 2023 •

edited

Function hasValidPrimaryReadReplicaConfig is a void function throwing only exceptions so if statement does not work.

if ($this->isPrimaryReadReplicaConfigured($driver)) {
    if($this->hasValidPrimaryReadReplicaConfig($driver)) {
        $connection_configuration = (new PrimaryReadReplicaConnection($this->config, $connection_configuration))->resolve($driver);
    }
}

Proposal:

if ($this->isPrimaryReadReplicaConfigured($driver)) {
    $this->hasValidPrimaryReadReplicaConfig($driver);
    $connection_configuration = (new PrimaryReadReplicaConnection($this->config, $connection_configuration))->resolve($driver);
}

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment