Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wikidata plugin depends on a deprecated package #230

Open
kamoshi opened this issue Nov 1, 2023 · 1 comment
Open

Wikidata plugin depends on a deprecated package #230

kamoshi opened this issue Nov 1, 2023 · 1 comment
Labels
dependencies Pull requests that update a dependency file

Comments

@kamoshi
Copy link

kamoshi commented Nov 1, 2023

I get the following warning when updating this package:

 WARN  1 deprecated subdependencies found: wikidata-sdk@8.1.1

This subdependency can be found here:
https://github.com/citation-js/citation-js/blob/main/packages/plugin-wikidata/package.json

The package wikidata-sdk has been renamed to wikibase-sdk.

@larsgw larsgw added the dependencies Pull requests that update a dependency file label Nov 1, 2023
@larsgw
Copy link
Owner

larsgw commented Nov 1, 2023

I am aware of the situation with wikidata-sdk, though I did not realize users of citation-js would get warnings too. wikidata-sdk was a wrapper around wikibase-sdk before v9.0.0 of the latter was released. Since wikibase-sdk v9.0.0 however, the module uses ESM-only instead of CommonJS which would force citation-js (and its users) to switch to ESM-only too. So the deprecated wikidata-sdk is still the latest available version. I will see if I can avoid the deprecation warning anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants