fork & upstreaming

[paulirish]

Hiya!

Thanks very much for making this module. I had looked for something similar a few times and usually came up empty handed. But yesterday this sorted things out for me. And I managed to get a HAR of the npm client doing an install. Pretty awesome.

I ended up changing a few things and wasn't sure if they were compatible, so I forked: https://github.com/paulirish/request-capture-har

But maybe it's possible that your project here can absorb all the changes. Here's the basic changelog:

• paulirish/request-capture-har@7bb25bd Use request instead of requestPromise. This is the big one, so more on this one later
• paulirish/request-capture-har@3211718 includes a stub pages object in the HAR, which many HAR viewers expect.
• paulirish/request-capture-har@3e54832 use time:true to get elapsedTime data from request, so we don't need to set endTime inside here.
• paulirish/request-capture-har@c27ee2e & paulirish/request-capture-har@22f6a91 I submitted a PR to request yesterday that adds support for the responseStartTime timing. (And it's already merged!) This now enables us to know the timing split between waiting for server and downloading (which you can see in the screenshot).

request & request-promise

As the codebase I was in (and typically am) uses streaming APIs on request, request-promise does not work for me; they don't support the .on() APIs at all. I'm curious if request-har-capture could work with both request APIs. It might have to be a breaking change, but I can imagine it working... maybe something like.. var request = require('request-har-capture')('request-promise');

What do you think? Are you interested in seeing if we can support both?

[larsthorup]

Hey @paulirish! Thanks for contributing these improvements! I am quite embarassed to say I only saw this issue yesteday, after almost a year. Somehow I had disabled notifications for this repo. Sorry about that :(

I will attempt to migrate to your fork, and if that works well, I might deprecate this one.