Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templates: remove build step from deploy scripts #2582

Closed
holic opened this issue Apr 1, 2024 · 1 comment · Fixed by #2839
Closed

templates: remove build step from deploy scripts #2582

holic opened this issue Apr 1, 2024 · 1 comment · Fixed by #2839
Labels
good first issue Good for newcomers

Comments

@holic
Copy link
Member

holic commented Apr 1, 2024

mud/templates/react/packages/contracts/package.json

Lines 9 to 10 in 66865c5

"deploy:local": "pnpm run build && mud deploy",
"deploy:testnet": "pnpm run build && mud deploy --profile=lattice-testnet",

this happens automatically inside mud deploy

mud/templates/react/packages/contracts/package.json

Line 11 in 66865c5

"dev": "pnpm mud dev-contracts",

can also change this to mud dev-contracts

then the scripts look a lot cleaner and more consistent:

"build": "mud build",
"clean": "forge clean && rimraf src/codegen",
"deploy:local": "mud deploy",
"deploy:testnet": "mud deploy --profile=lattice-testnet",
"dev": "mud dev-contracts",
@holic holic added the good first issue Good for newcomers label Apr 1, 2024
@blackbeard002
Copy link
Contributor

Hello @holic, can I take this up?

blackbeard002 added a commit to blackbeard002/mud that referenced this issue Apr 1, 2024
@blackbeard002
remove build step from deploy scripts latticexyz#2582
3eb677c
@blackbeard002 blackbeard002 mentioned this issue Apr 1, 2024
Closed
holic pushed a commit that referenced this issue May 15, 2024
@blackbeard002 @holic
remove build step from deploy scripts #2582
5d75498
@holic holic mentioned this issue May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
MUD
Status: Done
Milestone
No milestone
2 participants
@holic @blackbeard002