Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor writeContract and sendTransaction #2728

Open
alvrs opened this issue Apr 25, 2024 · 0 comments
Open

Refactor writeContract and sendTransaction #2728

alvrs opened this issue Apr 25, 2024 · 0 comments

Comments

@alvrs
Copy link
Member

alvrs commented Apr 25, 2024

  • we don't need writeContract anymore since it uses sendTransaction internally. All our custom logic can go into sendTransaction
  • use an action for estimateFeesPerGas that caches the latest value and polls to refresh in the background instead of FeeRef
  • use getAction(client, sendTransaction, "sendTransaction") instead of viem_sendTransaction
  • if a nonce is passed in as a parameter, we should prioritise it
  • add the block tag for nonce manager as an option
  • allow configuring repricing logic for replacing txs with overlapping nonces (i.e. latest block tag for nonce then nonce gets reset but there's already txs in the mempool)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant