Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider adding hostname to register delegation #2794

Open
holic opened this issue May 6, 2024 · 1 comment
Open

consider adding hostname to register delegation #2794

holic opened this issue May 6, 2024 · 1 comment

Comments

@holic
Copy link
Member

holic commented May 6, 2024

when we create an app signer, we tie the signed message to the hostname signing it to ensure one app signer per hostname

however, there's no way to retrieve this later on if we want to e.g. list all of your delegations, balances associated, and hostnames to recover the app signer to withdraw balance

not sure I love putting the hostname<>signer/account relationship onchain but services like relay already add metadata like this to the chain so maybe it's fine/not a huge security/privacy risk?

@holic
Copy link
Member Author

holic commented May 7, 2024

if we only care about this in the context of account kit and if we plan to move account kit to a single hostname to serve iframes, we may not need to worry about this because the one hostname should have all of this in localstorage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant