Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Customized Scrollbar Feature #333

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

akhilender-bongirwar
Copy link
Member

Description
Refactored the CSS code to introduce a custom scrollbar consistent with modern design trends. The new scrollbar design aligns with the desired appearance, replacing the default one.

Changes Made:

  • Added custom scrollbar CSS rules.
  • Removed the default scrollbar appearance.

These adjustments have been carefully implemented to maintain the smooth
and polished UI.

This PR fixes #327

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

In response to user feedback, this commit addresses the spacing concerns within the GetNighthawk website's UI. The existing design was visually appealing but lacked sufficient spacing between certain components.

Changes Made:
- Added margin-bottom to the analysis, distribution, and standards-based cards to create a clear distinction between them and improve readability.
- Introduced appropriate spacing between the 'Nighthawk & Meshery' section and the 'Layer 7 Performance Analysis' division to enhance the overall visual balance.

These adjustments have been carefully implemented to maintain the smooth and polished UI while ensuring a more comfortable viewing experience for users. The improved spacing creates a harmonious layout, allowing each component to breathe and stand out effectively.

Resolves Issue: layer5io#290

Signed-off-by: Akhilender akhilenderb9@gmail.com
Signed-off-by: Akhilender <akhilenderb9@gmail.com>
Refactored the CSS code to introduce a custom scrollbar consistent with modern design trends. The new scrollbar design aligns with the desired appearance, replacing the default one.

Changes Made:
- Added custom scrollbar CSS rules.
- Removed the default scrollbar appearance.

These adjustments have been carefully implemented to maintain the smooth
and polished UI.

Resolves Issue: layer5io#327

Signed-off-by: Akhilender <akhilenderb9@gmail.com>
In response to user feedback, this commit addresses the spacing concerns within the GetNighthawk website's UI. The existing design was visually appealing but lacked sufficient spacing between certain components.

Changes Made:
- Added margin-bottom to the analysis, distribution, and standards-based cards to create a clear distinction between them and improve readability.
- Introduced appropriate spacing between the 'Nighthawk & Meshery' section and the 'Layer 7 Performance Analysis' division to enhance the overall visual balance.

These adjustments have been carefully implemented to maintain the smooth and polished UI while ensuring a more comfortable viewing experience for users. The improved spacing creates a harmonious layout, allowing each component to breathe and stand out effectively.

Resolves Issue: layer5io#290

Signed-off-by: Akhilender <akhilenderb9@gmail.com>
Refactored the CSS code to introduce a custom scrollbar consistent with modern design trends. The new scrollbar design aligns with the desired appearance, replacing the default one.

Changes Made:
- Added custom scrollbar CSS rules.
- Removed the default scrollbar appearance.

These adjustments have been carefully implemented to maintain the smooth
and polished UI.

Resolves Issue: layer5io#327

Signed-off-by: Akhilender <akhilenderb9@gmail.com>
@netlify
Copy link

netlify bot commented Aug 31, 2023

Website preview ready!

Name Link
🔨 Latest commit f17775a
🔍 Latest deploy log https://app.netlify.com/sites/getnighthawk/deploys/64fb4d7b2a704100082df2a2
😎 Deploy Preview https://deploy-preview-333--getnighthawk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@malaviya-parth malaviya-parth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Have this type of styling on the scrollbar to keep it in Sync for all websites
Reference: Layer5.io

- Made the required changes for the custom scrollbar to be in sync with
  remaining all websites of Layer5 Organization.

Signed-off-by: Akhilender <akhilenderb9@gmail.com>
Copy link

@malaviya-parth malaviya-parth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change
::-webkit-scrollbar-thumb:hover { background: rgb(85, 91, 102); }
to
::-webkit-scrollbar-thumb:hover { background: rgb(85, 85, 85); }


Other things for the scrollbar are as required Great job🚀!

Signed-off-by: Akhilender <akhilenderb9@gmail.com>
@akhilender-bongirwar
Copy link
Member Author

Sure @malaviya-parth. Thank you : ) ...

Copy link

@malaviya-parth malaviya-parth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code for scrollbar in docs/_sass/getnighthawk.scss differs from the one you defined in docs/_sass/layout.scss either remove the scrollbar code from docs/_sass/getnighthawk.scss if this doesn't work then make it the same to the one in docs/_sass/layout.scss.
Also the margin changes was not defined in the issue, so I guess we should it as it was originally.

malaviya-parth

This comment was marked as spam.

Signed-off-by: Akhilender Bongirwar <112749383+akhilender-bongirwar@users.noreply.github.com>
Removed the extra spacing code form the issue customscrollbar.

Signed-off-by: Akhilender Bongirwar <112749383+akhilender-bongirwar@users.noreply.github.com>
@akhilender-bongirwar
Copy link
Member Author

@malaviya-parth, Could you please review the changes.

Copy link

@malaviya-parth malaviya-parth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@akhilender-bongirwar
Copy link
Member Author

@malaviya-parth , Could you please merge the PR : )

@malaviya-parth
Copy link

@malaviya-parth , Could you please merge the PR : )

I can't as I am currently don't hold that position, but don't worry after the discussion in the meeting, Maintainers will merge it.

Copy link
Member

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for this @akhilender-bongirwar

@Savio629
Copy link
Member

Savio629 commented Oct 2, 2023

LGTM 👍

@abhijeetgauravm
Copy link
Contributor

LGTM. Thanks for this @akhilender-bongirwar

// @Mohith234

@Mohith234
Copy link
Member

@leecalcote ^^

Copy link

@iArchitSharma iArchitSharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Custom Scroll-Bar
7 participants