Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix Documentation] update the CONTRIBUTING.md with Issues & Pull Requests sectionsd Issues & Pull Requests, Reviewing Pull Requests #353

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sandramsc
Copy link
Member

Description

This PR fixes #338

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Updated the CONTRIBUTING.md by adding an Issues & Pull Requests, Reviewing Pull Requests section

Signed-off-by: Sandra Ashipala <sandraashipala@gmail.com>
Copy link

welcome bot commented Dec 7, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@sandramsc sandramsc changed the title Adde[Fix Documentation] update the CONTRIBUTING.md with Issues & Pull Requests sectionsd Issues & Pull Requests, Reviewing Pull Requests [Fix Documentation] update the CONTRIBUTING.md with Issues & Pull Requests sectionsd Issues & Pull Requests, Reviewing Pull Requests Dec 7, 2023


1. Search existing Issues before creating a new Issue (look to see if the Issue has already been created).
1. If it doesn't exist create a new Issue giving as much context as possible (please take note and select the correct Issue type, for example `bug`, `documentation` or `feature`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rephrase by removing the repeated words such as search, see, look.
It would be great if words like issue , pull requests to be in lowercase when they are not at start of the sentence.

Copy link

@goldfishdolphin goldfishdolphin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider rephrasing the repetitive terms to be specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] update the CONTRIBUTING.md with Issues & Pull Requests sections
2 participants