Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[components]: Create custom DataFormatter #334

Open
5 tasks
Tracked by #402
nebula-aac opened this issue Nov 14, 2023 · 0 comments · May be fixed by #452
Open
5 tasks
Tracked by #402

[components]: Create custom DataFormatter #334

nebula-aac opened this issue Nov 14, 2023 · 0 comments · May be fixed by #452
Assignees
@nebula-aac
Labels
component/components kind/enhancement Improvement in current feature v0.13.0-planning

Comments

@nebula-aac
Copy link
Contributor

nebula-aac commented Nov 14, 2023 •
edited

Meshery UI has a component called DataFormatter

https://github.com/meshery/meshery/tree/master/ui/components/DataFormatter

  • Create custom component in custom directory of sistent-components
  • Create CopyIcon on a separate PR first
  • Component relies on lodash, please use good judgement to either place this package in sistent-components or suggest an alternative
  • LaunchIcon is being used from Material UI v4 - create new icon in svg first instead of using LaunchIcon from Material UI v4
  • Use existing components in sistent-components first (inline styles or global)

Contributor Guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nebula-aac nebula-aac

Labels
component/components kind/enhancement Improvement in current feature v0.13.0-planning
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add DataFormatter Components sudhanshutech/sistent
1 participant
@nebula-aac