Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I fix #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

I fix #6

wants to merge 3 commits into from

Conversation

CompuIves
Copy link

@CompuIves CompuIves commented Aug 23, 2019

Fixes #5

Thanks for taking the effort to create a PR!

If you are creating an extensive PR, you might want to open an issue with your idea first, so that you don't put a lot of effort in an PR that wouldn't be accepted. Please prepend pull requests with WIP: if they are not yet finished
PR checklist:

  • Added unit tests
  • Updated changelog
  • Updated docs (either in the description of this PR as markdown, or as separate PR on the gh-pages branch. Please refer to this PR). For new functionality, at least API.md should be updated
  • Added typescript typings
  • Verified that there is no significant performance drop (npm run perf)

Feel free to ask help with any of these boxes!

The above process doesn't apply to doc updates etc.

@codesandbox-drafts-staging
Copy link

codesandbox-drafts-staging bot commented Aug 23, 2019

This pull request is automatically built and testable in CodeSandbox!
To see build info of the built libraries, click Details below or on the icon next to each push.

Latest deployment of this branch, based on commit 5aa54db.

Sandbox Source
j308537xoy Configuration
j308537xoy Issue #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oh no! I have an issue
1 participant