Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop out player outside of the app (new window) #3145

Open
tzarebczan opened this issue Oct 29, 2019 · 3 comments
Open

Pop out player outside of the app (new window) #3145

tzarebczan opened this issue Oct 29, 2019 · 3 comments
Labels
area: viewer needs: exploration Solution unclear, needs research type: new feature New functionality that does not exist yet

Comments

@tzarebczan
Copy link
Contributor

We discussed this with the community on Discord at one point and it was brought up again as a feature request by a user. The idea would be that you can pop out the pop-out player to a new window. This would be useful in a multi-monitor setup or to make sure that the player is not interfering with app usage.

@tzarebczan tzarebczan added needs: exploration Solution unclear, needs research type: new feature New functionality that does not exist yet labels Oct 29, 2019
@DispatchCommit
Copy link
Contributor

The player had a Picture-in-picture popout option that basically meets your requirements (you can still right click->pip), but it was removed from the player UI.

We could restore the PiP button but style and position it separately from the other UI elements if needed.

Regarding performance profiling though, the player users a webworker for decoding, and the remaining usage goes towards the UI (updating the DOM for the trackbar, current timestamp, etc).

I think just adding back a button for PiP would be the simplest, easiest option here.

@tzarebczan
Copy link
Contributor Author

This feature was intended for the desktop app and having a popout as a new window of the electron application.

@Dark4Codrutz
Copy link

Dark4Codrutz commented Apr 10, 2021

Is it possible in Electron to use a video overlay like in chromium with the built-in PiP functionality ?

EDIT: I've found this old small project that does it DIY
https://github.com/krokofant/electron-picture-in-picture

There seem to have been a pull request on electron main branch exactly for this feature:
electron/electron#17686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: viewer needs: exploration Solution unclear, needs research type: new feature New functionality that does not exist yet
Projects
None yet
Development

No branches or pull requests

3 participants