Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thumbnails in LBRY #3703

Open
lyoshenka opened this issue Nov 9, 2022 · 0 comments
Open

thumbnails in LBRY #3703

lyoshenka opened this issue Nov 9, 2022 · 0 comments

Comments

@lyoshenka
Copy link
Member

lyoshenka commented Nov 9, 2022

the goal is to store claim thumbnails within the LBRY network

changes

  • every command that takes thumbnail_url also takes thumbnail_path, a path on the local filesystem to the thumbnail image
  • if given, the sdk turns that file into a stream and puts the sd hash into the thumbnail Source. it also makes the file available on the DHT

there might be some complexity in the file manager or stream manager because we used to have the assumption that one claim = one stream. but with this, one claim might have two streams (the stream itself and the thumbnail)

open questions

  • there's no way to store image dimensions. is that ok?
  • what filetypes are acceptable for thumbnails?
  • how to return thumbnail data back to the app?
  • will displaying a list of claims be slow because you have to download all the thumbnails?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant