Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] downloading update files fails for relative urls #22

Open
obiwanzenobi opened this issue Jun 22, 2022 · 1 comment
Open

[Windows] downloading update files fails for relative urls #22

obiwanzenobi opened this issue Jun 22, 2022 · 1 comment

Comments

@obiwanzenobi
Copy link

If I create appcast like in the example with relative update files urls, then download procedure fails on windows. Everything works well if url is an absolute one like https://you.com/update.exe

            <enclosure url="1.1.0+2/auto_updater_example-1.1.0+2-windows.exe"
                       sparkle:dsaSignature="MEUCIQCVbVzVID7H3aUzAY5znpi+ySZKznkukV8whlMFzKh66AIgREUGOmvavlcg6hwAwkb2o4IqVE/D56ipIBshIqCH8rk="
                       sparkle:version="1.1.0"
                       sparkle:os="windows"
                       length="0"
                       type="application/octet-stream" />

This is probably because of this line in win sparkle code:
https://github.com/vslavik/winsparkle/blob/b246977b9666953af6c647b36317add7a4e6250b/src/download.cpp#L200

Maybe windows implementation could be switched to one supporting relative urls to preserve compatibility with macos sparkle.
https://github.com/NetSparkleUpdater/NetSparkle
NetSparkleUpdater/NetSparkle#57

@ksm-android
Copy link

ksm-android commented Jan 8, 2023

Instead of the relative URL use http://localhost:5000/1.1.0+2/auto_updater_example-1.1.0+2-windows.exe.

Here localhost:5000 will be your local server domain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants