Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Github permissions #36

Open
leoasis opened this issue Dec 30, 2016 · 2 comments
Open

Clarify Github permissions #36

leoasis opened this issue Dec 30, 2016 · 2 comments

Comments

@leoasis
Copy link

leoasis commented Dec 30, 2016

First of all, super awesome initiative, super thankful for making Apollo easier to learn every day.

Now onto this particular issue: in the video tutorial, the permissions asked by github are only for public account info, but in my case when I tried to authorize the app with Github, it also asked for all info about my public repos, including write access to code, settings, webhooks and deploy keys. I think these permissions are way too much, and feels like they are not really needed. Is this intentional though? If it is, what is this being used for?

screen shot 2016-12-30 at 11 37 07 am

Thanks again for the hard work, and sorry if any of this does not make sense

@marktani
Copy link

Hey, thanks for the feedback 🙂

Unfortunately the videos are slightly outdated by nature, as the text/code changes multiple times a week and we cannot update the videos as often. We added a checkbox to star this repository when signing up, that's what we use the permission for:

la-github-star-permission

If you uncheck the box, you are back to the permissions as seen in the video. Hope this clears things up!

@leoasis
Copy link
Author

leoasis commented Dec 30, 2016

Cool, yeah it does! Thanks! (probably worth saying so next to the check label?)

@marktani marktani reopened this Dec 30, 2016
@marktani marktani changed the title Github permissions Clarify Github permissions Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants