Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pytest to 6.2.5 #11728

Open
2 tasks
rtibbles opened this issue Jan 12, 2024 · 4 comments · May be fixed by #11759
Open
2 tasks

Update pytest to 6.2.5 #11728

rtibbles opened this issue Jan 12, 2024 · 4 comments · May be fixed by #11759
Assignees
Labels
DEV: backend Python, databases, networking, filesystem... help wanted Open source contributors welcome work-in-progress Not ready for review

Comments

@rtibbles
Copy link
Member

rtibbles commented Jan 12, 2024

Our version of pytest was pinned to a very old version for back compatibility with Python 2.7.

Now that we have dropped support for 2.7, we can upgrade pytest to versions that support Python 3.6 and above.

While technically, 7.0.1 may work, there have been issues reported with Python 3.10 (cc @jredrejo), so it seems safer to upgrade to 6.2.5, as we would not be able to upgrade to newer versions of the 7 series, as they drop support for Python 3.6, which we still support.

We would also need to update any pytest plugins, and remove the existing patching of pytest for Python 3.10 compatibility.

Acceptance Criteria

@rtibbles rtibbles added DEV: backend Python, databases, networking, filesystem... help wanted Open source contributors welcome labels Jan 12, 2024
@thesujai
Copy link
Contributor

I would like to give this a try.
Can i be assigned to this one?

@AlexVelezLl
Copy link
Member

Hi @thesujai! Sure! I have assigned this issue to you 👐. Let us know if you have any questions.

@thesujai
Copy link
Contributor

@rtibbles how do i approach this one. How I amd doing is going through https://docs.pytest.org/en/stable/changelog.html and checking for the Removals.

@rtibbles
Copy link
Member Author

There are two ways of doing it - you can go through the changelog and check for removals, or you can just do the upgrade and then run pytest locally to see what breaks!

I would suggest a hybrid strategy - get a good sense of what has changed in the Changelog, and if you can see any obvious things that you can preempt that might be a problem with the upgrade, try to fix those alongside the initial upgrade. Then try out running pytest and see what breaks to start to fix it.

To reduce your iteration time, you can also run pytest with only a single test file (it shouldn't matter too much which one it is, but maybe try a couple).

@thesujai thesujai linked a pull request Jan 20, 2024 that will close this issue
9 tasks
@akolson akolson added the work-in-progress Not ready for review label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... help wanted Open source contributors welcome work-in-progress Not ready for review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants