Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiz creation: Snackbars improvements #12038

Closed
5 tasks
nucleogenesis opened this issue Mar 29, 2024 · 0 comments · Fixed by #12080
Closed
5 tasks

Quiz creation: Snackbars improvements #12038

nucleogenesis opened this issue Mar 29, 2024 · 0 comments · Fixed by #12080
Assignees

Comments

@nucleogenesis
Copy link
Member

Overview

The Snackbars in the quiz creation are currently overly hacked together in part due to the known issues around how Coach's global router guards.

Currently, the Snackbar messages are being passed around by way of route.query.snackbar which is, to say the least, wack. This causes snackbar messages to show because clearing the value of the query param is a redundant route navigation.

Acceptance criteria

  • Update the Coach app.js so that it does not clear the snackbar whenever we're navigating to one of the routes listed in the skipLoading variable.
  • In each of the side panel files (SectionEditor, ReplaceQuestions, SelectResources) and the CreateQuizSection component, strip out the existing query-parameter related snackbar business.
  • Replace query-parameter solutions with direct calls to the createSnackbar action, typically will be during the beforeRouteLeave router guards.
  • When, for example, saving your replacements, you should see that the snackbar message shows as the side panel closes.
  • Additionally, you should never see a snackbar message when you're closing the side panel without saving your changes - ie, update the title in the SectionEditor, click the X, and confirm losing your changes... no snackbar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants