feat: support passing custom parser to recast #354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Thanks for the pull request. I have to say though, that I don't think it's the right way to fix this problem, because:
I think instead we should just completely replace the parser when espree is problematic. Perhaps you tried to do that and ran into problems. But if there are problems replacing the default one, then making it configurable is even more problematic. Anyway... these are my quick thoughts without digging deeply into this. |
|
Ok, I see your point. Will try to replace the parser. |
|
See #355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #352
This PR adds a third argument
optionsto thetransformmethod. User can pass anyparserthat is compatible with recast (example), thisparsershould have aparsemethod that accepts code and returns AST.Qustions:
destructParamimports the internal parser to parse the code, which is not covered by this PR. I'm not sure if I should change the transformer interface fromfunction(ast, logger)tofunction(ast, logger, parser)so that the parser config can cover all of the usage.