Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add support for running the project in a development container in VS Code #1945

Open
Juice10 opened this issue Mar 8, 2021 · 5 comments

Comments

@Juice10
Copy link

Juice10 commented Mar 8, 2021

vscode has the ability to add a configuration that will allow you to run your rails environment in a development container: https://code.visualstudio.com/docs/remote/create-dev-container
It would be great to add support for that.

@zernie
Copy link

zernie commented Sep 8, 2021

@ledermann I do have a dev config, would you be open for a PR?

@ledermann
Copy link
Owner

@zernie I don't use Docker for development because the last time I tried it (a long time ago) there were lots of issues. If it's useful these days, I'd be happy to see a PR.

@zernie
Copy link

zernie commented Sep 13, 2021

@zernie I don't use Docker for development because the last time I tried it (a long time ago) there were lots of issues. If it's useful these days, I'd be happy to see a PR.

btw I use https://github.com/ufoscout/docker-compose-wait for awaiting services. Would you be open to replacing your scripts with this tool as well (in a separate PR)?

@ledermann
Copy link
Owner

@zernie Regarding docker-compose-wait: I'm not convinced that including this would perform better than the existing wait-for-services.sh script. It works very well and uses just netcat which already exists in the Alpine image.

@zernie
Copy link

zernie commented Sep 18, 2021

@ledermann docker compose wait also uses netcat:) but it is also much easier to extend for new services and provides some very useful config vars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants