Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Reload seems to be broken in master #167

Open
chrischen opened this issue May 25, 2019 · 1 comment
Open

Hot Reload seems to be broken in master #167

chrischen opened this issue May 25, 2019 · 1 comment

Comments

@chrischen
Copy link

chrischen commented May 25, 2019

I just cloned master, and ran it on node 12.2.0.

Hot reloading doesn't give any errors

image

However the component doesn't actually re-render.

Reloading the page loads the new changes.

@chrischen
Copy link
Author

chrischen commented May 30, 2019

The last working revision was 31a95bf and on a6abe69 HMR stopped working.

My system is macOS Mojave and tested with Chrome and Safari.

After further debugging it seems

  1. I can get dynamic import()'d modules to hot reload by wrapping the export of the function component in hot().
  2. example/index.tsx cannot hot reload no matter if I wrap it in hot() or not.
    a) if example/index.tsx is imported in root.tsx without using the "@/.." alias and with a relative path, the page is at least reloaded to reflect changes to index.tsx.
  3. modules imported (static imports) and mounted as a child in example/index.tsx hot reloads without needing to wrap the export in hot().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant