Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Spec has no expectations" warnings with karma-jasmine-html-reporter 1.x #87

Open
rkrzewski opened this issue May 30, 2018 · 0 comments

Comments

@rkrzewski
Copy link

I've upgraded my test harness to jasmine 3.1.0 and karma-jasmine-html-reporter 1.1.0 and started getting tons of warnings of missing expectations in all my testcheck tests.

This is where the check is hapening
https://github.com/dfederm/karma-jasmine-html-reporter/blob/master/src/lib/html.jasmine.reporter.js#L491-L494

And the reason why passedExpectations array is empty, even though expectations were checked during testcheck property evaluation is here:
https://github.com/leebyron/testcheck-js/blob/master/integrations/jasmine-check/jasmine-check.js#L78-L84

On one hand, the warning is harmless if a bit annoying, on the other that is an useful check to have. I've prepared a workaround that is backward compatible with jasmine 1.x and 2.x that I'll post shortly

rkrzewski added a commit to rkrzewski/testcheck-js that referenced this issue May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant