findIndex should not be in Data.Massiv.Vector

[dschrempf]

Hi! Thank you for this great package!

I just wrote my own findIndex function for general arrays before finding a similar function in Data.Massiv.Vector. I think the function findIndex should be moved to a more general module!

Thank you!

EDIT: Or, maybe. move the function and add a specialized one to Data.Massiv.Vector?

[lehins]

The function itself is defined and exported from: Data.Massiv.Array.Manifest.findIndex

massiv/massiv/src/Data/Massiv/Array/Manifest.hs

Lines 217 to 222 in 01ac573

	-- | /O(n)/ - Perform a row-major search starting at @0@ for an element. Returns the index
	-- of the first occurance of an element or `Nothing` if a predicate could not be satisifed
	-- after it was applyied to all elements of the array.
	--
	-- @since 0.5.5
	findIndex :: (Index ix, Manifest r e) => (e -> Bool) -> Array r ix e -> Maybe ix

It is merely re-exported from Data.Massiv.Vector and Data.Massiv.Array modules. I am not sure there is benefit of removing re-export and redefining a specialized version in Data.Massiv.Vector

I think a better solution would be instead of re-exporting the full Data.Massiv.Array.Manifest re-export functions from the module in Data.Massiv.Array in organized manner.

There is quite a bit documentation improvement massiv could use. PRs are always welcome.

[dschrempf]

I see, thank you for the explanation.

I just didn't find this or any similar function in the documentation of Data.Massiv.Array. Yes, an organized re-export would be the preferred solution...