Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Docker Image #970

Open
melroy89 opened this issue Dec 16, 2021 · 3 comments · May be fixed by #973
Open

Create a Docker Image #970

melroy89 opened this issue Dec 16, 2021 · 3 comments · May be fixed by #973
Labels
ci related to Lektor's continous integration deploy enhancement

Comments

@melroy89
Copy link

Hi,

I think this project needs an official Docker image / Dockerfile. Which is pushed to DockerHub automatically via GH Actions.

This would be very useful in pipelines, like building a website in GitLab CI/CD Pipelines using the official Lektor Docker image.

I suspect it's not hard to introduce such a Dockerfile.

Regards,
Melroy
@dairiki
Copy link
Contributor

dairiki commented Dec 16, 2021

This is a very interesting idea. Thank you.

@dairiki dairiki added ci related to Lektor's continous integration deploy enhancement labels Dec 16, 2021
@melroy89
Copy link
Author

melroy89 commented Dec 16, 2021 •
edited

Seeing all the problem I have trying to install Lektor locally (using installer.py aghm). Maybe this Docker image should use pipx as well.

EDIT: As mentioned here: #915

@melroy89
Copy link
Author

melroy89 commented Dec 16, 2021 •
edited

ps. Please also consider adding a (extension of the) Docker image that includes the i18n plugin: https://github.com/numericube/lektor-i18n-plugin . Which is required for my build personally.
Never mind: I think that needs to be done manually on the CLI for each project.

Or.. Maybe yes.. Maybe prepare the Docker image to have at least gettext + babel via pip preinstalled as well.

@dairiki dairiki linked a pull request Dec 17, 2021 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci related to Lektor's continous integration deploy enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create a docker image dairiki/lektor
2 participants
@dairiki @melroy89