Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR status not showing up all checks #494

Closed
simov opened this issue Apr 11, 2015 · 10 comments
Closed

PR status not showing up all checks #494

simov opened this issue Apr 11, 2015 · 10 comments

Comments

@simov
Copy link

simov commented Apr 11, 2015

I created a test PR here simov/request#1 where the Show all checks button is available, so I can click on it and see all of the checks, including the coverage report.

Then I created the same PR but in request request/request#1541 - here I can see only the default Details button which points to the travis build.

I can confirm that the data is sent correctly to coveralls.io https://coveralls.io/builds/2316175

The repo settings seems to be set correctly to use the Status API, but it seems to be not reporting back.

@simov
Copy link
Author

simov commented Apr 13, 2015

@nickmerwin could that be related to the fact that I'm not the one who initially added request to coveralls? Currently I'm an owner of the request org and my coveralls access token have granted access to the status API (obviously) but that doesn't work for the request repo only.

I can see the repo settings to the left here https://coveralls.io/r/request/request I'm not seeing only the delete repository section to the right, and that might have something to do with the fact that the repository was not added initially by me?

@nickmerwin
Copy link
Member

Hi @simov sorry for the delay! Yes, the repo is owned by @nylen, so the status API call is made on his behalf.

@nylen if you're listening could you logout and back into Coveralls? It seems your OAuth credential have rolled.

Thank you!

@simov
Copy link
Author

simov commented Apr 18, 2015

Thanks for the response @nickmerwin is there any chance to transfer the ownership to me? Because certainly I'm the one responsible for the coveralls integration but I didn't had the ownership rights back then. And @nylen is nowhere to be seen lately.

@nylen
Copy link

nylen commented Apr 18, 2015

@nickmerwin I've re-authorized request on Coveralls. Let me know if that fixes the issue. And, 👍 for transferring ownership to @simov.

@simov
Copy link
Author

simov commented Apr 18, 2015

Doesn't seems to be working. At first I got some weird git error then I force pushed one commit and everything passed again, plus the coveralls report is being created, but without status messages. I'm no longer seeing the Show all checks button even for my own repo

@simov
Copy link
Author

simov commented Apr 23, 2015

@nickmerwin this is our latest PR on coveralls still no luck with the status API.

@karyon
Copy link

karyon commented May 4, 2016

We do have the same problem in this repo, here's a pull request with which we tested this. Comments from coveralls are working, the status API is not. Like the original reporter, coveralls support for the repo was added by someone else (@cyroxx) who does not have access to the repository anymore, current admin is @janno42.

@cyroxx: hi :)

@karyon
Copy link

karyon commented May 4, 2016

fwiw #526 seems to be the same issue.

@karyon
Copy link

karyon commented May 8, 2016

deleting the repository from coveralls and re-adding it fixed the issue.

@stale
Copy link

stale bot commented Apr 3, 2020

This issue has been automatically marked for closure because it has not had recent activity. It will be closed if no further activity occurs. If your issue is still active please add a comment and we’ll review as soon as we can. Thank you for your contributions.

@stale stale bot closed this as completed Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants