Fastfetch bug

[theRoboxx]

Describe the bug
fastfetch crashes when listing the Shell parameter

To Reproduce
Steps to reproduce the behavior:

1. Run fastfetch in foot-client
2. Displays information until Shell parameter
3. Shell parameter doesn't get displayed and freezes

Expected behavior
The fastfetch command should list every Laptop information

Screenshots
Fish vs. Clifm

Desktop (please complete the following information):

• OS: Nixos Unstable 24.05
• Terminal: Foot
• CliFM version: clifm 1.18 (Mar 23, 2024)
• Installation source: nix unstable branch

[leo-arch]

Hi @theRoboxx. Reproduced with version 18.0. However, the issue is not there in the latest git version. Please give it a try.

[muellerto]

clifm 1.18.4 (Apr 22, 2024)

[muellerto]

OK, on my Arch it says just "clifm":

[leo-arch]

Thanks for your confirmation @muellerto.

As to the Shell field showing clifm (on Linux), I'm not sure why (but this is most likely related to fastfetch rather than to clifm itself). It might be because fastfetch is getting the running shell by consulting the parent PID, but I'm not sure.

EDIT: Yeap, that's what it actually seems to be doing (i.e. checking /proc/PID/stat):

https://github.com/fastfetch-cli/fastfetch/blob/445dd94b53f0903f35989dca47eeaa6edeb53f86/src/detection/terminalshell/terminalshell_linux.c#L124

[CarterLi]

Happened to find this.

Fastfetch have resolved similar issues by adding them to ignore list. I can do the same for clifm if needed.

[leo-arch]

That would be great @CarterLi. Thanks!

[CarterLi]

Just tried clifm. Seems that clifm spawn $SHELL process to run shell commands, so that the process tree is: terminal > shell > clifm > shell > fastfetch

So the problematic module should be Terminal instead of Shell

Really curious why it worked differently in @muellerto's screenshot.

Anyway, I will make fastfetch ignore clifm in both Shell & Terminal module

[leo-arch]

the process tree is: terminal > shell > clifm > shell > fastfetch

This is true.

As to the Terminal field, I'm getting the right value, no matter what terminal I use.

Btw, I normally run clifm under valgrind, in which case fastfetch takes valgrind as my shell. I guess you should add valgrind to the shell ignore list too.

[CarterLi]

okey