Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properties with into and default attribute calls into() in proc macro #2407

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Properties with into and default attribute calls into() in proc macro #2407

wants to merge 1 commit into from

Conversation

gzp79
Copy link

@gzp79 gzp79 commented Mar 5, 2024

resolves #2386

Into() is added to the default_code when the prop is into and there's a default expression

@gzp79 gzp79 changed the title Properries with into and default attribute calls into() Properties with into and default attribute calls into() in proc macro Mar 5, 2024
@gbj
Copy link
Collaborator

gbj commented Mar 8, 2024

Thanks for this contribution! Apart from all the noise of examples failing CI due to the need for a cargo-leptos update (I'm rerunning those right now) this also fails on the formatting check in leptos_macro -- if you just cargo fmt there and push it should resolve that issue. Looks good to me otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make #prop(into, default) a bit more ergonomic.
2 participants
@gzp79 @gbj