We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
In 0.15.5, the initializer and sign method for class ClientSecretJWT looked like this:
def __init__(self, token_endpoint=None, claims=None, header=None): self.token_endpoint = token_endpoint self.claims = claims self.header = header def sign(self, auth, token_endpoint): return client_secret_jwt_sign( auth.client_secret, client_id=auth.client_id, token_endpoint=token_endpoint, claims=self.claims, header=self.header, alg=self.alg, )
See here: https://github.com/lepture/authlib/blob/v0.15.5/authlib/oauth2/rfc7523/auth.py#L30
In 1.0.0+, the same looks like this:
def __init__(self, token_endpoint=None, claims=None, alg=None): self.token_endpoint = token_endpoint self.claims = claims if alg is not None: self.alg = alg def sign(self, auth, token_endpoint): return client_secret_jwt_sign( auth.client_secret, client_id=auth.client_id, token_endpoint=token_endpoint, claims=self.claims, alg=self.alg, )
See here: https://github.com/lepture/authlib/blob/v1.0.1/authlib/oauth2/rfc7523/auth.py#30
The header kwarg has disappeared. I was using that for my application, and now it's no longer possible to use that.
header
Are the 1.0.0 and 0.15.x trees unrelated? They don't look like the share the same history. Is there documentation on what happened here?
Error Stacks
"__init__() got an unexpected keyword argument 'header'"
To Reproduce
N/A
Expected behavior
I expected the class ClientSecretJWT to retain the header kwarg and have it be possible to use it.
Environment:
The text was updated successfully, but these errors were encountered:
Add headers back to ClientSecretJWT, fixing #457
49c5556
lepture
No branches or pull requests
Describe the bug
In 0.15.5, the initializer and sign method for class ClientSecretJWT looked like this:
See here: https://github.com/lepture/authlib/blob/v0.15.5/authlib/oauth2/rfc7523/auth.py#L30
In 1.0.0+, the same looks like this:
See here: https://github.com/lepture/authlib/blob/v1.0.1/authlib/oauth2/rfc7523/auth.py#30
The
header
kwarg has disappeared. I was using that for my application, and now it's no longer possible to use that.Are the 1.0.0 and 0.15.x trees unrelated? They don't look like the share the same history. Is there documentation on what happened here?
Error Stacks
To Reproduce
N/A
Expected behavior
I expected the class ClientSecretJWT to retain the header kwarg and have it be possible to use it.
Environment:
The text was updated successfully, but these errors were encountered: