Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): create release when using custom tag-version-separator #837

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Apr 2, 2024

Description

Follows original Lerna PR 3979

After the 8.1.0, the version command does not create a GitHub release when using a custom version seperator. This was because the createRelease function had a hard coded @ in tag name filter.

Motivation and Context

to fix issue with custom version tag separator not working without @

How Has This Been Tested?

Per Lerna PR

To test, I create a test repo made changes to a packages and commit them. I then ran:

node /tmp/lerna/dist/packages/lerna/dist/cli.js version --tag-version-separator '-' --conventional-commits --create-release github --yes

And was able to see the new GitHub release created with the appropriate tag

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ghiscoding ghiscoding merged commit 5fa6184 into main Apr 2, 2024
4 checks passed
@ghiscoding ghiscoding deleted the bugfix/custom-tag-version-separator branch April 2, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant