Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate bot is not ignored despite using default config #414

Open
lostfictions opened this issue Feb 25, 2021 · 1 comment
Open

Renovate bot is not ignored despite using default config #414

lostfictions opened this issue Feb 25, 2021 · 1 comment

Comments

@lostfictions
Copy link

Hi there, I see that (via #105) lerna-changelog is supposed to exclude PRs by bots like Renovate by default:

if (!ignoreCommitters) {
ignoreCommitters = [
"dependabot-bot",
"dependabot[bot]",
"greenkeeperio-bot",
"greenkeeper[bot]",
"renovate-bot",
"renovate[bot]",
];
}

However, this doesn't seem to be working for my repo, and I can't figure out a manual config to get it to work either. Are there limitations to how it works, or did something maybe break in the time since that PR was merged a few years back?

@lostfictions
Copy link
Author

lostfictions commented Feb 26, 2021

Poking around a bit, it looks like ignoreCommitters is only referenced here:

private ignoreCommitter(login: string): boolean {
return this.config.ignoreCommitters.some((c: string) => c === login || login.indexOf(c) > -1);
}

This in turn is only referenced by getCommitters, which is only used for filling out contributor info at the bottom of a release, not for actually filtering commits. And indeed, bots are correctly ignored in the list of contributors, even if their commits are included in the changelog. For example, I'm seeing output like this:

Bug Fix

Committers: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant